slop/huge-commits
Commits are reviewable
| Severity | info |
| Tiers | all |
| Stacks | any |
| Scope | root |
| Kind | expr |
| Source | library v0.4.0 |
| Selected by | fleetlint-slop@v0.4.0 |
Requirement
No commit in the recent history (params.commits, default 200) changes more than params.max_lines lines (default 1500). The root commit, usually an initial import, is exempt.
Why
A commit that large was not reviewed line by line, and cannot be reverted without taking unrelated changes with it.
Applies when
repo.has_gitCheck
For each item in:
commits(params.commits)item.lines <= params.max_lines || item.rootParameters
commits:200max_lines:1500
Fix
Split work into commits of one concern each.
Agent instruction: Commit one concern at a time. Do not rewrite pushed history without the user’s decision.
Sources
- https://google.github.io/eng-practices/review/developer/small-cls.html (style-guide)
- https://fleetlint.org/baseline/#slop (convention)
- https://fleetlint.org/slop/#commits-and-history
Generated by fleetlint docs from catalog v0.4.0.